Maint/simplify gesture event emitting #1617
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickeZ
force-pushed
the
maint/simplify-gesture-event-emitting
branch
from
c5ce0c5 to
4c72f70
Compare
|
Please rebase if still relevant. |
NickeZ
force-pushed
the
maint/simplify-gesture-event-emitting
branch
from
4c72f70 to
136f814
Compare
done |
benma
reviewed
Oct 13, 2025
Comment on lines
266
to
233
| _emit_continuous_slide_event(); | ||
| _emit_slide_release_event(); | ||
| _emit_long_tap_event(); | ||
| _emit_short_tap_event(); | ||
| _emit_continuous_tap_event(); | ||
| for (int location = 0; location < TOUCH_NUM_SLIDERS; location++) { | ||
| for (int event_idx = 0; event_idx < EVENT_ENUM_MAX; event_idx++) { | ||
| if (_emit_event_detect_fns[event_idx](location)) { | ||
| _gesture_emit_event(event_idx, location); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
The order of events is changed. Could that have an impact somewhere?
There was a problem hiding this comment.
fair point, refactored so that it is functionally equivalent. please rereview :)
NickeZ
force-pushed
the
maint/simplify-gesture-event-emitting
branch
from
136f814 to
e3fb25f
Compare
NickeZ
force-pushed
the
maint/simplify-gesture-event-emitting
branch
from
e3fb25f to
fd7f416
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.